Skip to content

Add DMPC order parameters from JACS 1997 - #386

Merged
comcon1 merged 6 commits into
NMRLipids:mainfrom
annasandtorv:add-exp-Sandtorv-2026
Apr 25, 2026
Merged

Add DMPC order parameters from JACS 1997#386
comcon1 merged 6 commits into
NMRLipids:mainfrom
annasandtorv:add-exp-Sandtorv-2026

Conversation

@annasandtorv

Copy link
Copy Markdown
Contributor

No description provided.

Comment on lines +38 to +40
"M_G2C3_M, M_G2C3H1_M": [
[-0.14, 0.02]
],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know which one is, which? @tfmFerreira

Comment on lines +10 to +14
DETAILS:
At the C2 position, the sn-1 chain has a single value (degenerate), while the sn-2 chain exhibits two distinct values due to motional
inequivalence (forking). The identification of which value belonged to the sn-1 chain was determined using Seelig, A. and
Seelig, J. (Biochemistry 1974, 13, 4839). The stereospecific assignment of the two sn-2 values to specific hydrogens was
estimated based on experimental values for POPC at 300K (DOI: 10.1039/c2cp42738a).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not allowed to write multistrings in YAML in that way. It should be

tag: | 
   string1
   string2
or_tag: > 
   string1
   string2

SOD: 0
CLA: 0
CAL: 0
TOTAL_LIPID_CONCENTRATION: 50

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is wrong. This is an outdated tag that we need to get rid of. Unfortunately, we still need to fill it. It's not 50. It's 55.5/(water_per_lipid)
50 is probably a mass % that is a new tag which is described in the documentation. It is called differently.

@@ -0,0 +1,23 @@
DOI: 10.1021/ja962951b

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an outdated tag. Please call it ARTICLE_DOI if its a paper or DATA_DOI if it's a dataset.

@comcon1

comcon1 commented Apr 17, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution. I attached some comments to my review.

Comment thread experiments/OrderParameters/10.1021/acs.jacs.ja962951b/1/README.yaml Outdated
Comment thread experiments/OrderParameters/10.1021/acs.jacs.ja962951b/1/README.yaml Outdated
@comcon1

comcon1 commented Apr 19, 2026

Copy link
Copy Markdown
Member

Thx @annasandtorv. I've added a couple of suggestions. You can read them and then go to "Files:" tab where you can apply them. After that -- LGTM.

annasandtorv and others added 2 commits April 21, 2026 10:21
…E.yaml

Co-authored-by: Alexey Nesterenko <comconadin@gmail.com>
…E.yaml

Co-authored-by: Alexey Nesterenko <comconadin@gmail.com>
@comcon1

comcon1 commented Apr 25, 2026

Copy link
Copy Markdown
Member

@annasandtorv you should request review again when you are ready. Otherwise I don't get notification. Thanx for your efforts. I will approve and merge.

@comcon1
comcon1 merged commit 580f10e into NMRLipids:main Apr 25, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants